Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests for pytest_itde #357

Closed
ckunki opened this issue Jun 27, 2023 · 1 comment
Closed

Add additional tests for pytest_itde #357

ckunki opened this issue Jun 27, 2023 · 1 comment
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Jun 27, 2023

This ticket was triggered by a discussion on PR #354 and requests to enhance the tests for ITDE's pytest plugin.

Proposal: The test should

  • get a session wide database with random ports
  • verify ability start new databases with random ports

Rationale: using default ports in tests is in general somewhat dangerous.

Please review / fix grammar of the following statement:

In that case, we only need port CLI parameter, in case we want to supply a database from the outside.

@ckunki ckunki added the refactoring Code improvement without behavior change label Jun 27, 2023
@ckunki ckunki changed the title Add tests for pytest_itde Add aditional tests for pytest_itde Jun 27, 2023
@ckunki ckunki changed the title Add aditional tests for pytest_itde Add additional tests for pytest_itde Jun 27, 2023
@Nicoretti
Copy link
Contributor

pytest plugin isn't part of this repository anymore

@Nicoretti Nicoretti closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

2 participants