Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use wasmi 0.4.4 and remove the need for llvm #59

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Use wasmi 0.4.4 and remove the need for llvm #59

merged 1 commit into from
Jun 22, 2020

Conversation

axic
Copy link
Member

@axic axic commented Jun 9, 2020 •
edited
Loading

Part of #41.

@axic axic changed the title Use wabt 0.4.4 and remove the need for llvm Use wasmi 0.4.4 and remove the need for llvm Jun 9, 2020
@axic axic marked this pull request as ready for review June 9, 2020 22:57
@hugo-dc hugo-dc self-requested a review June 9, 2020 23:59
@axic axic force-pushed the wabt-upgrade branch 2 times, most recently from 8dcdf6d to 7bbbc88 Compare June 10, 2020 21:08
@hugo-dc
Copy link
Member

hugo-dc commented Jun 11, 2020

wasmi is building correctly, do we need to compare v0.4.4-benchmarking vs bench-time to see if there is a significant difference?

@axic axic force-pushed the wabt-upgrade branch 3 times, most recently from 8ace06b to eca736d Compare June 17, 2020 20:02
@axic axic merged commit 80152d9 into master Jun 22, 2020
@axic axic deleted the wabt-upgrade branch June 22, 2020 21:02
@axic axic mentioned this pull request Jun 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugo-dc hugo-dc Awaiting requested review from hugo-dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axic @hugo-dc