-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the version/commithash/date or each VM used #41
Comments
Suggestion: rebase these branches on top of the closest release and name them as |
Here is the list of versions of VMs used:
|
@jwasinger @hugo-dc rebased the wasmi commit on wasmi 0.4.3 and moved the patch from It is available at https://github.com/ewasm-benchmarking/wasmi/tree/v0.4.3-benchmarking |
btw I tried that wasmi branch and I get an error:
|
Also pushed wasm3 v0.4.7-benchmarking: https://github.com/ewasm-benchmarking/wasm3/tree/v0.4.7-benchmarking |
Weird. We can try based those commits on v0.4.4: https://github.com/ewasm-benchmarking/wasmi/tree/v0.4.4-benchmarking |
We should also use git tags and not git branches on The reason: those can not be changed (well, not as easily as branches), so the benchmarking is way more reproducible. |
New suggestion:
The reason: the tags can't be modified easily, but the branches are easily noticeable if we want to work on them later. |
Updates:
|
I tried figuring out the a closeby release for wasmtime but I think it is just too far apart. Would be nice to use a newer wasmtime, but for now I suggest we leave it alone. Closing this and opening a tracking issue for wasmtime. |
Can start collecting that here in the issue, but eventually should be documented in the readme or similar.
The hash is the upstream hash the branch is based on.
benchmark
) 130d7d07d0ee649a38b9b8df7d22404d960b2f09 / Jan 2020 / closest tag: WAMR-02-18-2020 (6 commits behind)benchmark
) 565b585697291a864d127f3cd3c383cebd80ab1e / 30 Dec 2019 / closest tag: v0.4.2 (5 commits behind)bench-times
) e9f4420cbd6da59babf15527294da199116aa0ff / 22 Feb 2019 / closest tag: 0.4.0 (3 commits behind)bench-time
) 23b054c0e5139f0266b6189deb4279749b8058d5 / 20 Jan 2019 / closest tag: 0.4.4 (5 commits behind)The text was updated successfully, but these errors were encountered: