Skip to content
This repository has been archived by the owner on Dec 20, 2023. It is now read-only.

imp: deprecate ethereum-ledger-go components #8

Merged
merged 42 commits into from
Dec 8, 2022
+2,136 −492
Merged

imp: deprecate ethereum-ledger-go components #8

Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
d3a9077
imp: deprecate ethereum-ledger-go components
fedekunze Dec 4, 2022
91463d3
conflict
fedekunze Dec 4, 2022
366ddd5
refactor OS check to const
Dec 5, 2022
3871ae9
remove unused wallet method signText
Dec 5, 2022
f1faacc
address gocritic error regarding appending not to the same slice
Dec 5, 2022
289e73b
address stylecheck ST1005 comment regarding capitalized error strings
Dec 5, 2022
6c94313
further small (Goland) linter fixes
Dec 5, 2022
e7cee38
chore(test): move test helpers to utils
4rgon4ut Dec 5, 2022
f93a383
change semgrep.yml to use evmos-ledger-go as safe directory
Dec 5, 2022
f16b4d8
2nd try to fix get-diff error happening during semgrep.yml workflow
Dec 5, 2022
04ca03f
fix get-diff error while executing semgrep.yml workflow
Dec 5, 2022
d93d7c2
fix questionable assignment semgrep error in usbwallet/ledger.go
Dec 5, 2022
14c7efc
add gosec ignore lines for the expected failures
Dec 5, 2022
64946ad
some minor adjustments to comments
Dec 5, 2022
1ab101c
address semgrep error regarding questionable assignment
Dec 5, 2022
bed1d06
replace gosec ignore error code G109 with G701 for integer conversion
Dec 5, 2022
ef10d84
refactor using first byte of ledger exchange reply as integer
Dec 5, 2022
00f7395
rework some comments in ledger.go
Dec 5, 2022
c7dc679
address review comments
Dec 5, 2022
a5d2176
replace remaining occurence of empty byte array as return value in ca…
Dec 5, 2022
0c81546
remove URL field in account struct
Dec 5, 2022
64df7ad
add comment to SignTypedMessage message
Dec 5, 2022
fe83d27
Merge branch 'fedekunze/merge-ledger' of github.com:evmos/evmos-ledge…
4rgon4ut Dec 6, 2022
bcefa1a
chore: remove SignTx && ledgerSign; replace SECP256K1 interface
4rgon4ut Dec 6, 2022
d9389c9
chore: fixed linter triggers
4rgon4ut Dec 6, 2022
953ebba
Apply suggestions from code review
fedekunze Dec 6, 2022
67df8fb
remove nosec before system time call because CodeQL doesn't support this
Dec 7, 2022
af0cf5d
add blank identifier to ignored errors when closing devices in wallet.go
Dec 7, 2022
99a8868
ignore linter warnings about unhandled errors when closing devices in…
Dec 7, 2022
7ae989a
fix Makefile commands to run the tests
Dec 7, 2022
4481e5e
use correct gosec codes for ignoring unhandled errors
Dec 7, 2022
4d2e45a
tests refactor (#10)
4rgon4ut Dec 7, 2022
211e31c
Update .github/workflows/test.yml
fedekunze Dec 7, 2022
3230141
Update .github/workflows/test.yml
fedekunze Dec 7, 2022
90c7524
fix: fix derivation issue
austinchandra Dec 8, 2022
24c6a30
address gosec integer overflow warning
Dec 8, 2022
b60733b
minor cleanups
Dec 8, 2022
e60c380
fix make test-unit-cover
Dec 8, 2022
8f588ab
Merge branch 'main' into fedekunze/merge-ledger
MalteHerrmann Dec 8, 2022
e390145
remove unused function verifyTypedDataFields
Dec 8, 2022
d81b8a4
remove unused variables from usbwallet/ledger.go
Dec 8, 2022
39714bc
(fix): remove unused suite attributes
Vvaradinov Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update .github/workflows/test.yml
@fedekunze
fedekunze authored Dec 7, 2022

Verified

This commit was signed with the committer’s verified signature. The key has expired.
danielleadams Danielle Adams
GPG key ID: D3A89613643B6201
Expired
Verified
Learn about vigilant mode
commit 211e31c820305e732d79a6631256856a11c2b71b
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ jobs:
- name: Test and Create Coverage Report
# FIXME: make test-unit-cover fails
run: |
go test ./... -coverprofile=coverage.txt -covermode=atomic
make test-unit-cover
if: env.GIT_DIFF
- uses: codecov/[email protected]
with: