This repository has been archived by the owner on Dec 20, 2023. It is now read-only.
imp: deprecate ethereum-ledger-go components #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
gosec found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
|
|
||
| w.healthQuit = make(chan chan error) | ||
|
|
||
| go w.heartbeat() |
Check notice
Code scanning / CodeQL
Spawning a Go routine
GAtom22
reviewed
Dec 5, 2022
| "time" | ||
|
|
||
| //#nosec -- runtime is listed as a potential source for non-determinism, but we use it only for checking the OS | ||
| "runtime" |
Check notice
Code scanning / CodeQL
Sensitive package import
Co-authored-by: Vladislav Varadinov <[email protected]> Co-authored-by: Federico Kunze Küllmer <[email protected]>
fedekunze
commented
Dec 7, 2022
fedekunze
commented
Dec 7, 2022
austinchandra
had a problem deploying
to
release
GitHub Actions
Failure
austinchandra
had a problem deploying
to
release
GitHub Actions
Failure
Vvaradinov
approved these changes
Dec 8, 2022
GAtom22
approved these changes
Dec 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.