Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

gas cost is different from go-ethereum #287

Closed
yihuang opened this issue Jul 14, 2021 · 1 comment · Fixed by #288
Closed

gas cost is different from go-ethereum #287

yihuang opened this issue Jul 14, 2021 · 1 comment · Fixed by #288
Assignees
@yihuang

Comments

@yihuang
Copy link
Contributor

yihuang commented Jul 14, 2021 •
edited
Loading

System info: ethermint main, geth recent version

Steps to reproduce:

  1. run geth devnet with berlin hardfork activated
  2. run ethermint devnet
  3. compare the gas cost of same contract transaction

Expected behavior: should be the same

Actual behavior: different, after trace the opcode, the SLOAD cost 2900 on ethermint, but 2100 on geth

Additional info: [Include gist of relevant config, logs, etc.]
@yihuang yihuang self-assigned this Jul 14, 2021
@leejw51crypto
Copy link
Contributor

check GetEthIntrinsicGas

@yihuang yihuang mentioned this issue Jul 14, 2021
Merged
11 tasks
yihuang referenced this issue in yihuang/ethermint Jul 14, 2021
@yihuang
fix order of eip activation
c3bf215 
Closes: #287
fedekunze pushed a commit that referenced this issue Jul 14, 2021
@yihuang
evm: fix ExtraEIP activation (#288)
84febdd 
Closes: #287
yihuang referenced this issue in yihuang/ethermint Jul 15, 2021
@yihuang
treat all vm errors the same as reverted
86c259d 
Closes: #274

evm: fix `ExtraEIP` activation (#288)

Closes: #287

Update x/evm/types/utils.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Add `Failed` utility function and changelog
fedekunze pushed a commit that referenced this issue Jul 15, 2021
@yihuang
evm: treat all vm errors the same as reverted (#276)
297a35d 
Closes: #274

evm: fix `ExtraEIP` activation (#288)

Closes: #287

Update x/evm/types/utils.go

Co-authored-by: Federico Kunze Küllmer <[email protected]>

Add `Failed` utility function and changelog
mmsqe referenced this issue in mmsqe/ethermint Jul 11, 2023
@mmsqe
update default params for test (#287)
7dfd2b2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihuang yihuang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix order of eip activation yihuang/ethermint
2 participants
@yihuang @leejw51crypto