This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #288 +/- ##
=======================================
Coverage 47.54% 47.54%
=======================================
Files 45 45
Lines 3136 3136
=======================================
Hits 1491 1491
Misses 1570 1570
Partials 75 75
|
fedekunze
approved these changes
Jul 14, 2021
fedekunze
reviewed
Jul 14, 2021
fedekunze
approved these changes
Jul 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
seems that a test case is failing @yihuang |
Closes: #287
seems that set to |
yihuang
referenced
this pull request
in yihuang/ethermint
Jul 15, 2021
Closes: #274 evm: fix `ExtraEIP` activation (#288) Closes: #287 Update x/evm/types/utils.go Co-authored-by: Federico Kunze Küllmer <[email protected]> Add `Failed` utility function and changelog
fedekunze
pushed a commit
that referenced
this pull request
Jul 15, 2021
Closes: #274 evm: fix `ExtraEIP` activation (#288) Closes: #287 Update x/evm/types/utils.go Co-authored-by: Federico Kunze Küllmer <[email protected]> Add `Failed` utility function and changelog
mmsqe
referenced
this pull request
in mmsqe/ethermint
Aug 2, 2023
* Problem: abci handshake is not shutdown gracefully Solution: - use cancellable node constructor * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * fix grpc-only * better app close * log error --------- Signed-off-by: yihuang <[email protected]>
mmsqe
referenced
this pull request
in mmsqe/ethermint
Sep 5, 2023
* Problem: abci handshake is not shutdown gracefully Solution: - use cancellable node constructor * Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> * fix grpc-only * better app close * log error --------- Signed-off-by: yihuang <[email protected]>
mmsqe
referenced
this pull request
in mmsqe/ethermint
Sep 6, 2023
* Problem: abci handshake is not shutdown gracefully Solution: - use cancellable node constructor * Update CHANGELOG.md * fix grpc-only * better app close * log error --------- Signed-off-by: yihuang <[email protected]> Co-authored-by: yihuang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #287
Description
Remove the extra eips since we already activated Berlin hardfork in chain config.
Why wrong order cause issue:
SLOAD
's constant gas to 800, without touch dynamic gasSLOAD
to use dynamic gas(2100 for cold access) and set constant gas to zeroSo in the right order, the end result is 2100, but in reverse order, we get 2900.
Verified in external integration test.
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)