Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Convert HTTP Status Codes to Starlette constant values #438

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Convert HTTP Status Codes to Starlette constant values #438

merged 1 commit into from
Apr 28, 2022

Conversation

sanders41
Copy link
Contributor

Purpose

Make the use of status codes consistent.

Changes

  • Change status code number (i.e. 200) to the starlette constants (i.e. HTTP_200_OK).

Checklist

  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #413

TheAndrewJackson
TheAndrewJackson approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great!

@TheAndrewJackson TheAndrewJackson merged commit 5dd76ff into ethyca:main Apr 28, 2022
@sanders41 sanders41 deleted the status-codes branch April 28, 2022 19:31
adamsachs pushed a commit to adamsachs/fidesops_forked_test that referenced this pull request May 17, 2022
@sanders41
Convert HTTP Status Codes to Starlette constant values (ethyca#438)
b809dc7
sanders41 added a commit that referenced this pull request Sep 22, 2022
@sanders41
Convert HTTP Status Codes to Starlette constant values (#438)
b95f53c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Assignees

@TheAndrewJackson TheAndrewJackson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tech debt] Convert HTTP Status Codes to Starlette constant values
2 participants
@sanders41 @TheAndrewJackson