You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Switch all of the HTTP status codes to use the Starlette constants. This would help the code become more self documenting since a description each status is embedded within its name. It would come in handy when more niche statuses are used in the future like HTTP_413_REQUEST_ENTITY_TOO_LARGE.
This change will also follow the project standard of using constant values for magic strings that could be changed later like in the scope registry and urn registry files.
Describe alternatives you've considered, if any
We could hand roll our own constants if that's preferable or create a fidesops wrapper file the reimports all the Starlette constants. This would decouple us from Starlette and would reduce the refactoring required if we moved away from Starlette.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a specific problem?
Currently the codebase uses a mix of magic numbers and Starlette constant values
Describe the solution you'd like
Switch all of the HTTP status codes to use the Starlette constants. This would help the code become more self documenting since a description each status is embedded within its name. It would come in handy when more niche statuses are used in the future like
HTTP_413_REQUEST_ENTITY_TOO_LARGE
.This change will also follow the project standard of using constant values for magic strings that could be changed later like in the scope registry and urn registry files.
Describe alternatives you've considered, if any
We could hand roll our own constants if that's preferable or create a fidesops wrapper file the reimports all the Starlette constants. This would decouple us from Starlette and would reduce the refactoring required if we moved away from Starlette.
The text was updated successfully, but these errors were encountered: