Update frontend build path to be more descriptive #934
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #937
While working on https://github.com/ethyca/fidesctl-plus/pull/39, I found it would be more helpful if fidesctl was writing its frontend admin-ui to a folder that said it is the admin-ui. In addition, there didn't seem much a point to nesting it under
fidesctl/api/build/static
anymore, and I thought it would make more sense to have it undersrc/ui-build/static/admin
to make it clearer what is going on. This will also let us better add on other frontends if we need to, since we know this one will be in the subfolder /admin. So for instance, the datamap build can also go in the same folder, but under /datamap.Code Changes
Steps to Confirm
npm run prod-export
again. Then runningnox -s dev
should allow you to see the latest built frontend at localhost:8080. You'll have the build in thesrc/ui-build
folder instead offidesctl/api/build/static
now.Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats