Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend build path to be more descriptive #934

Merged
merged 6 commits into from
Jul 25, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jul 21, 2022

Closes #937

While working on https://github.com/ethyca/fidesctl-plus/pull/39, I found it would be more helpful if fidesctl was writing its frontend admin-ui to a folder that said it is the admin-ui. In addition, there didn't seem much a point to nesting it under fidesctl/api/build/static anymore, and I thought it would make more sense to have it under src/ui-build/static/admin to make it clearer what is going on. This will also let us better add on other frontends if we need to, since we know this one will be in the subfolder /admin. So for instance, the datamap build can also go in the same folder, but under /datamap.

Code Changes

  • Renaming the constants in the backend
  • Renaming the folder path in the package.json script
  • Updating the gitignore

Steps to Confirm

  • Everything should still work the same. Can delete any old frontend build you had, and run npm run prod-export again. Then running nox -s dev should allow you to see the latest built frontend at localhost:8080. You'll have the build in the src/ui-build folder instead of fidesctl/api/build/static now.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking allisonking marked this pull request as ready for review July 22, 2022 14:20
@allisonking allisonking requested review from a team and ssangervasi July 22, 2022 14:20
Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 🎉

@allisonking allisonking merged commit 73a770b into main Jul 25, 2022
@allisonking allisonking deleted the aking-frontend-build-path branch July 25, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update frontend build path to a more flexible/descriptive place
2 participants