Skip to content

Commit

Permalink
Update frontend build path to be more descriptive (#934)
Browse files Browse the repository at this point in the history
* Update frontend build path to be more descriptive

* Update changelog

* Update dockerignore

* Update dockerfile reference paths
  • Loading branch information
allisonking authored Jul 25, 2022
1 parent 1c26a67 commit 73a770b
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 5 deletions.
1 change: 1 addition & 0 deletions .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
build/
dist/
src/fidesctl.egg-info/
src/ui-build/

# Ignore Python-Specific Files
.mypy_cache/
Expand Down
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
docs/fides/docs/api/openapi.json
docs/fides/docs/schemas/config_schema.json
fidesctl/api/ctl/build/static
ui-build/

## generic files to ignore
*~
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ The types of changes are:
* Update `fideslang` to `1.1.0`, simplifying the default taxonomy and adding `tags` for resources [#865](https://github.com/ethyca/fides/pull/865)
* Remove the `obscure` requirement from the `generate` endpoint [#819](https://github.com/ethyca/fides/pull/819)
* Merge existing configurations with `fideslib` library [#913](https://github.com/ethyca/fides/pull/913)
* Moved frontend static files to `src/ui-build/static` [#934](https://github.com/ethyca/fides/pull/934)

### Developer Experience

Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ ENV PYTHONUNBUFFERED=TRUE
ENV RUNNING_IN_DOCKER=TRUE

# Make a static files directory
RUN mkdir -p src/fidesctl/api/ctl/build/static
RUN mkdir -p src/ui-build/static/admin

EXPOSE 8080
CMD ["fidesctl", "webserver"]
Expand All @@ -116,4 +116,4 @@ RUN python setup.py sdist
RUN pip install dist/fidesctl-*.tar.gz

# Copy frontend build over
COPY --from=frontend /fides/clients/admin-ui/out/ /fides/src/fidesctl/api/ctl/build/static/
COPY --from=frontend /fides/clients/admin-ui/out/ /fides/src/ui-build/static/admin/
2 changes: 1 addition & 1 deletion clients/admin-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"analyze:server": "cross-env BUNDLE_ANALYZE=server next build",
"analyze:browser": "cross-env BUNDLE_ANALYZE=browser next build",
"export": "next build && next export",
"copy-export": "rsync -a --delete out/ ../../src/fidesctl/api/ctl/build/static/",
"copy-export": "rsync -a --delete out/ ../../src/ui-build/static/admin/",
"prod-export": "npm run export && npm run copy-export",
"cy:open": "cypress open",
"cy:run": "cypress run",
Expand Down
3 changes: 2 additions & 1 deletion src/fidesctl/api/ctl/routes/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
from fidesctl.api.ctl.utils.api_router import APIRouter

API_PREFIX = "/api/v1"
WEBAPP_DIRECTORY = Path("src/fidesctl/api/build/static")
FRONTEND_BUILD_DIRECTORY = Path("src/ui-build/static")
WEBAPP_DIRECTORY = FRONTEND_BUILD_DIRECTORY / "admin"
WEBAPP_INDEX = WEBAPP_DIRECTORY / "index.html"


Expand Down

0 comments on commit 73a770b

Please sign in to comment.