Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SQLAlchemy M1 greenlet missing bug #891

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Jul 12, 2022

Closes #816

Code Changes

  • add the asyncio option to sqlalchemy

Steps to Confirm

  • someone with an M1 mac confirms this fixes it

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Update CHANGELOG.md

Description Of Changes

Quick fix for a bug reported by an internal user, turns out to be an issue the M1 macs specifically and this should fix it, as suggested by this thread

@ThomasLaPiana ThomasLaPiana self-assigned this Jul 12, 2022
@ThomasLaPiana ThomasLaPiana marked this pull request as ready for review July 12, 2022 05:41
@ThomasLaPiana ThomasLaPiana requested a review from a team July 12, 2022 05:41
@ThomasLaPiana ThomasLaPiana merged commit 870501e into main Jul 12, 2022
@ThomasLaPiana ThomasLaPiana deleted the ThomasLaPiana-fix-sqlalchemy-greenlet branch July 12, 2022 16:27
allisonking pushed a commit that referenced this pull request Jul 28, 2022
* Update requirements.txt

* update the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing greenlet dependency for fidesctl[webserver]
2 participants