Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing greenlet dependency for fidesctl[webserver] #816

Closed
SteveDMurphy opened this issue Jun 28, 2022 · 7 comments · Fixed by #891
Closed

Missing greenlet dependency for fidesctl[webserver] #816

SteveDMurphy opened this issue Jun 28, 2022 · 7 comments · Fixed by #891
Assignees
Labels
bug Something isn't working

Comments

@SteveDMurphy
Copy link
Contributor

SteveDMurphy commented Jun 28, 2022

Bug Description

When starting up the webserver, an error is returned that greenlet is missing as a required dependency

Steps to Reproduce

  1. pip install "fidesctl[webserver]"
  2. fidesctl init
  3. fidesctl webserver

Expected behavior

The webserver should successfully start, this can be resolved temporarily by:

  1. pip install greenlet
  2. fidesctl webserver

Screenshots

n/a

Environment

  • Version: 1.7.0
  • OS: Darwin
  • Python Version: 3.9.12
  • Docker Version: 20.10.14

Additional context

Discovered as part of working my way through fidesdemo, I'm not sure this is actually an issue with fidesctl but potentially a different dependency 🤷🏽

@SteveDMurphy SteveDMurphy added the bug Something isn't working label Jun 28, 2022
@SteveDMurphy SteveDMurphy added this to the 1.7.1 milestone Jun 28, 2022
@sanders41
Copy link
Contributor

My guess is this has to do with SqlAlchemy, but I am not sure why it wouldn't install on it's own

install_requires =
    importlib-metadata;python_version<"3.8"
    greenlet != 0.4.17;(platform_machine=='aarch64' or (platform_machine=='ppc64le' or (platform_machine=='x86_64' or (platform_machine=='amd64' or (platform_machine=='AMD64' or (platform_machine=='win32' or platform_machine=='WIN32'))))))
    typing-extensions >= 4.1.0

@SteveDMurphy
Copy link
Contributor Author

Thanks for the lead @sanders41 ! Some secondary research made it seem like there may be something going on with one (or more) of our async calls that could be tripping this up as well...

@ThomasLaPiana ThomasLaPiana self-assigned this Jul 6, 2022
@ThomasLaPiana
Copy link
Contributor

note that #881 might affect this a bit, but I'll do some testing on this and see if I can't replicate it

@ThomasLaPiana
Copy link
Contributor

pipx install fidesctl[webserver] -> fidesctl webserver worked fine for me on my local machine 🤔

given that I used pipx it should be totally isolated, so I'm not sure what might be causing this

@sanders41
Copy link
Contributor

sanders41 commented Jul 12, 2022

With pipx install fidesctl[webserver] -> fidesctl webserver I do get the error. @ThomasLaPiana what is your system Python version? Are you on 3.8.x? Mine is 3.10.5, and @SteveDMurphy has 3.9.12. If not that maybe it as to do with M1 Macs.

@sanders41
Copy link
Contributor

Looks like it is an M1 issue. sqlalchemy/sqlalchemy#7714. The solution listed is to either add the asyncio extra to sqlalchemy, sqlchemy[asyncio] or to add greenlet to the requirements.

@ThomasLaPiana
Copy link
Contributor

thanks for the heads up @sanders41 ! I'll go ahead and do the first option and document that its a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants