Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new dataset via YAML #813

Merged
merged 12 commits into from
Jul 5, 2022
Merged

Add a new dataset via YAML #813

merged 12 commits into from
Jul 5, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jun 28, 2022 •
edited
Loading

Closes #708

Code Changes

  • Adds a CustomTextArea component
  • Adds js-yaml as a package to facilitate yaml parsing and validation
  • Adds a page where a user can paste in YAML
  • Adds POST to dataset endpoint to redux
  • Error handling

Steps to Confirm

  • At localhost:3000/dataset, click the now enabled "Create new dataset" button.
  • Click "Upload a new dataset YAML"
  • Paste in a dataset (i.e. from demo_resources/) and click "Create new dataset"

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Screen.Recording.2022-06-28.at.3.48.15.PM.mov

@allisonking allisonking marked this pull request as ready for review June 28, 2022 19:53
@ssangervasi
Copy link
Contributor

Looks like a cypress video snuck in.

@allisonking allisonking merged commit e9bcb31 into main Jul 5, 2022
@allisonking allisonking deleted the aking-708-new-dataset-yaml branch July 5, 2022 18:24
allisonking added a commit that referenced this pull request Jul 28, 2022
@allisonking
Add a new dataset via YAML (#813)
35c7016 
* Scaffold out new yaml

* Add Textarea component with yaml

* Make call to create dataset

* Update changelog

* Fixup invalidations

* Remove phrase highlighting per updated design

* Address PR feedback

* Use object syntax for responsive styles
@allisonking allisonking mentioned this pull request Aug 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssangervasi ssangervasi ssangervasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add button to upload a new dataset YAML
2 participants
@allisonking @ssangervasi