Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add button to upload a new dataset YAML #708

Closed
allisonking opened this issue May 25, 2022 · 0 comments · Fixed by #813
Closed

Add button to upload a new dataset YAML #708

allisonking opened this issue May 25, 2022 · 0 comments · Fixed by #813
Assignees
@allisonking
Labels
UI Work related to UI
Milestone
Fidesctl 1.7.1

Comments

@allisonking
Copy link
Contributor

allisonking commented May 25, 2022 •
edited by mfbrown
Loading

Is your feature request related to a specific problem?

I want to be able to upload a YAML file of a dataset into the system

Describe the solution you'd like

  • A button "Upload a new dataset YAML"
  • A text field for the user to paste a YAML into

Questions:

  • Should the frontend do the conversation from YAML to JSON to send to the backend? or is there a backend endpoint which accepts YAML?
  • error validation?

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Time estimate: 1-2 days, depending on how we go about uploading YAML to the backend. Longer if we have to do error validation too

Aha! Link: https://ethyca.aha.io/features/CTL-109
@allisonking allisonking added enhancement UI Work related to UI labels May 25, 2022
@allisonking allisonking added this to the 1.7.0 milestone May 25, 2022
@allisonking allisonking self-assigned this Jun 1, 2022
@ThomasLaPiana ThomasLaPiana modified the milestones: 1.7.0, 1.8.0 Jun 15, 2022
@mfbrown mfbrown modified the milestones: 1.8.0, 1.7.1 Jun 21, 2022
@allisonking allisonking mentioned this issue Jun 28, 2022
Merged
14 tasks
@allisonking allisonking mentioned this issue Jul 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@allisonking allisonking

Labels
UI Work related to UI
Projects
None yet
Milestone
Fidesctl 1.7.1
Development

Successfully merging a pull request may close this issue.

Add a new dataset via YAML ethyca/fides
3 participants
@mfbrown @ThomasLaPiana @allisonking