Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2051 notify users of discovery process after selecting resources for monitoring #4958

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Jun 6, 2024

Description Of Changes

After the user takes the action to monitor a resource, we should display a toast indicating that the resource is now monitor and that the results will appear later in the Data Discovery tab.

Code Changes

  • Add toast with message

Steps to Confirm

  • Setup a connection and monitor for Data discovery & detection
  • Go to Detection & Discovery > Activity
  • Click on Monitor on a resource
  • You should see the toast appear

Also:

  • Click on Ignore a resource
  • Go to Data detection and toggle "Show full schema" to see ignored resource
  • Click on Monitor on that ignored resource
  • You should see the toast appear

Screenshot

Captura de pantalla 2024-06-06 a la(s) 12 15 12 p  m

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 6, 2024 3:49pm

Lucano Vera added 2 commits June 6, 2024 12:24
…users-of-discovery-process-after-selecting-resources-for-monitoring
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's some minor linting issues, but otherwise this looks good! 🍎

Copy link

cypress bot commented Jun 6, 2024

Passing run #8163 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 3e5b191 into 806c646...
Project: fides Commit: d3a70ebceb ℹ️
Status: Passed Duration: 00:34 💡
Started: Jun 6, 2024 3:59 PM Ended: Jun 6, 2024 4:00 PM

Review all test suite changes for PR #4958 ↗︎

@lucanovera lucanovera merged commit cdbd777 into main Jun 6, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-2051-Notify-users-of-discovery-process-after-selecting-resources-for-monitoring branch June 6, 2024 16:28
lucanovera added a commit that referenced this pull request Jun 6, 2024
Copy link

cypress bot commented Jun 6, 2024

Passing run #8166 ↗︎

0 4 0 0 Flakiness 0

Details:

PROD-2051 notify users of discovery process after selecting resources for monito...
Project: fides Commit: cdbd777b6e
Status: Passed Duration: 00:33 💡
Started: Jun 6, 2024 4:38 PM Ended: Jun 6, 2024 4:39 PM

Review all test suite changes for PR #4958 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants