-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PROD-2051 notify users of discovery process after selecting resources for monitoring #4958
Merged
lucanovera
merged 5 commits into
main
from
PROD-2051-Notify-users-of-discovery-process-after-selecting-resources-for-monitoring
Jun 6, 2024
Merged
PROD-2051 notify users of discovery process after selecting resources for monitoring #4958
lucanovera
merged 5 commits into
main
from
PROD-2051-Notify-users-of-discovery-process-after-selecting-resources-for-monitoring
Jun 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…users-of-discovery-process-after-selecting-resources-for-monitoring
gilluminate
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there's some minor linting issues, but otherwise this looks good! 🍎
Passing run #8163 ↗︎Details:
Review all test suite changes for PR #4958 ↗︎ |
lucanovera
added a commit
that referenced
this pull request
Jun 6, 2024
… for monitoring (#4958) Co-authored-by: Lucano Vera <[email protected]>
Passing run #8166 ↗︎Details:
Review all test suite changes for PR #4958 ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
After the user takes the action to monitor a resource, we should display a toast indicating that the resource is now monitor and that the results will appear later in the Data Discovery tab.
Code Changes
Steps to Confirm
Also:
Screenshot
Pre-Merge Checklist
CHANGELOG.md