Skip to content

Commit

Permalink
PROD-2051 notify users of discovery process after selecting resources…
Browse files Browse the repository at this point in the history
… for monitoring (#4958)

Co-authored-by: Lucano Vera <[email protected]>
  • Loading branch information
lucanovera and Lucano Vera committed Jun 6, 2024
1 parent a0c9969 commit 8441329
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ The types of changes are:
- Fill custom privacy request fields with query_param_key [#4948](https://github.com/ethyca/fides/pull/4948)
- Add `datasource_params` column to MonitorConfig DB model [#4951](https://github.com/ethyca/fides/pull/4951)
- Added ability to open system preview side panel from new data map table [#4944](https://github.com/ethyca/fides/pull/4944)
- Added sucess toast message after monitoring a resource [#4958](https://github.com/ethyca/fides/pull/4958)
- Added UI for displaying, adding and editing discovery monitors [#4954](https://github.com/ethyca/fides/pull/4954)

### Changed
- Set default ports for local development of client projects (:3001 for privacy center and :3000 for admin-ui) [#4912](https://github.com/ethyca/fides/pull/4912)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {
} from "fidesui";
import { useState } from "react";

import { useAlert } from "~/features/common/hooks";
import { DiffStatus, StagedResource } from "~/types/api";

import { MonitorOffIcon } from "../common/Icon/MonitorOffIcon";
Expand All @@ -32,6 +33,7 @@ const DetectionItemAction: React.FC<DetectionItemActionProps> = ({
const [confirmResourceMutation] = useConfirmResourceMutation();
const [muteResourceMutation] = useMuteResourceMutation();
const [unmuteResourceMutation] = useUnmuteResourceMutation();
const { successAlert } = useAlert();

const [isProcessingAction, setIsProcessingAction] = useState(false);

Expand Down Expand Up @@ -73,6 +75,10 @@ const DetectionItemAction: React.FC<DetectionItemActionProps> = ({
staged_resource_urn: resource.urn,
monitor_config_id: resource.monitor_config_id!,
});
successAlert(
"Data discovery has started. The results may take some time to appear in the “Data discovery“ tab.",
`${resource.name || "The resource"} is now being monitored.`
);
setIsProcessingAction(false);
}}
disabled={isProcessingAction}
Expand All @@ -87,6 +93,10 @@ const DetectionItemAction: React.FC<DetectionItemActionProps> = ({
await unmuteResourceMutation({
staged_resource_urn: resource.urn,
});
successAlert(
"Data discovery has started. The results may take some time to appear in the “Data discovery“ tab.",
`${resource.name || "The resource"} is now being monitored.`
);
setIsProcessingAction(false);
}}
disabled={isProcessingAction}
Expand Down

0 comments on commit 8441329

Please sign in to comment.