Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendors disclosed entirely from fides.js #4553

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Remove vendors disclosed entirely from fides.js #4553

merged 3 commits into from
Jan 11, 2024

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Jan 10, 2024 •
edited
Loading

Closes N/A. See slack discussion here: https://ethyca.slack.com/archives/CBKK8TS74/p1704904930579039?thread_ts=1704898783.839119&cid=CBKK8TS74

Description Of Changes

Removes the vendors disclosed portion of the TC string entirely

Code Changes

  • When encoding the TC string, remove specification for vendors disclosed
  • Update tests

Steps to Confirm

  • Fides events should no longer contain the vendors disclosed sections, and neither should the cookie

Pre-Merge Checklist

@vercel Vercel
Copy link

vercel bot commented Jan 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2024 5:18pm

@cypress Cypress
Copy link

cypress bot commented Jan 10, 2024 •
edited
Loading

Passing run #5937 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 2fdf749 into a398d99...
Project: fides Commit: 2483e029f6 ℹ️
Status: Passed Duration: 00:33 💡
Started: Jan 10, 2024 5:28 PM Ended: Jan 10, 2024 5:29 PM

Review all test suite changes for PR #4553 ↗︎

@allisonking allisonking marked this pull request as ready for review January 10, 2024 17:34
eastandwestwind
eastandwestwind approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@eastandwestwind eastandwestwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@allisonking allisonking merged commit 475d1e7 into main Jan 11, 2024
13 checks passed
@allisonking allisonking deleted the aking/remove-vendors-disclosed branch January 11, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

@NevilleS NevilleS Awaiting requested review from NevilleS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonking @eastandwestwind