Parameterize Salesforce Refresh Token (#4547)

Co-authored-by: Adrian Galvan <[email protected]>
ethyca · Jan 10, 2024 · a398d99 · a398d99
1 parent 9efd423
commit a398d99
Show file tree

Hide file tree

Showing 3 changed files with 24 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -21,9 +21,9 @@ The types of changes are:
 - Erasure support for AppsFlyer [#4512](https://github.com/ethyca/fides/pull/4512)
 
 ### Fixed
+- Fixed an issue blocking Salesforce sandbox accounts from refreshing tokens [#4547](https://github.com/ethyca/fides/pull/4547)
 - Fixed DSR zip packages to be unzippable on Windows [#4549](https://github.com/ethyca/fides/pull/4549)
 
-
 ## [2.27.0](https://github.com/ethyca/fides/compare/2.26.0...2.27.0)
 
 ### Added

diff --git a/data/saas/config/salesforce_config.yml b/data/saas/config/salesforce_config.yml
@@ -4,7 +4,7 @@ saas_config:
   type: salesforce
   description: A sample schema representing the Salesforce Classic connector for Fides
   user_guide: https://docs.ethyca.com/user-guides/integrations/saas-integrations/salesforce
-  version: 0.0.5
+  version: 0.0.6
 
   connector_params:
     - name: domain
@@ -19,6 +19,10 @@ saas_config:
     - name: redirect_uri
       label: Redirect URL
       description: The Fides URL to which users will be redirected upon successful authentication
+    - name: token_refresh_url
+      label: Token Refresh URL
+      description: The Salesforce URL for refresh tokens. This should not be changed unless using a Sandbox account, when it should be set to test.salesforce.com
+      default_value: login.salesforce.com
 
   client_config:
     protocol: https
@@ -57,7 +61,7 @@ saas_config:
           method: POST
           client_config:
             protocol: https
-            host: login.salesforce.com
+            host: <token_refresh_url>
           path: /services/oauth2/token
           headers:
             - name: Content-Type

diff --git a/data/saas/dataset/salesforce_dataset.yml b/data/saas/dataset/salesforce_dataset.yml
@@ -170,7 +170,7 @@ dataset:
             fidesops_meta:
               data_type: string
           - name: Title
-            data_categories: [system.operations]
+            data_categories: [user.job_title]
             fidesops_meta:
               data_type: string
           - name: Department
@@ -391,19 +391,23 @@ dataset:
             fidesops_meta:
               data_type: string
           - name: ContactPhone
-            data_categories: [user.contact.phone_number]
+            data_categories: [system.operations]
+            description: Phone data derived from the Contact collection
             fidesops_meta:
               data_type: string
           - name: ContactMobile
-            data_categories: [user.contact.phone_number]
+            data_categories: [system.operations]
+            description: Phone data derived from the Contact collection
             fidesops_meta:
               data_type: string
           - name: ContactEmail
-            data_categories: [user.contact.email]
+            data_categories: [system.operations]
+            description: Email data derived from the Contact collection
             fidesops_meta:
               data_type: string
           - name: ContactFax
-            data_categories: [user.contact]
+            data_categories: [system.operations]
+            description: Fax data derived from the Contact collection
             fidesops_meta:
               data_type: string
           - name: Comments
@@ -842,7 +846,7 @@ dataset:
             fidesops_meta:
               data_type: string
           - name: Name
-            data_categories: [user.name]
+            data_categories: [user.contact.organization]
             fidesops_meta:
               data_type: string
           - name: Type
@@ -886,7 +890,8 @@ dataset:
             fidesops_meta:
               data_type: string
           - name: BillingAddress
-            data_categories: [user.contact]
+            data_categories: [system.operations]
+            description: Derived field from other billing address components
             fidesops_meta:
               data_type: string
           - name: ShippingStreet
@@ -922,23 +927,24 @@ dataset:
             fidesops_meta:
               data_type: string
           - name: ShippingAddress
-            data_categories: [user.contact]
+            data_categories: [system.operations]
+            description: Derived field from other shipping address components
             fidesops_meta:
               data_type: string
           - name: Phone
             data_categories: [user.contact.phone_number]
             fidesops_meta:
               data_type: string
           - name: Fax
-            data_categories: [user.contact]
+            data_categories: [user.contact.fax_number]
             fidesops_meta:
               data_type: string
           - name: AccountNumber
             data_categories: [system.operations]
             fidesops_meta:
               data_type: string
           - name: Website
-            data_categories: [system.operations]
+            data_categories: [user.contact.url]
             fidesops_meta:
               data_type: string
           - name: PhotoUrl
@@ -978,7 +984,7 @@ dataset:
             fidesops_meta:
               data_type: string
           - name: Site
-            data_categories: [system.operations]
+            data_categories: [user.location]
             fidesops_meta:
               data_type: string
           - name: OwnerId