Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dynamic class name for TCF-variant of consent banner #4404

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Nov 8, 2023

Description Of Changes

Fixes an accidentally-backwards ternary I added to #4403! Whoops.

Code Changes

  • Update ConsentBanner

Steps to Confirm

  • Check the correct classes and CSS are added for TCF and non-TCF variants of banner:
    • Regular banner does not add fides-tcf-banner-container class
    • Regular banner does not add undefined class
    • TCF banner adds fides-tcf-banner-container class

Pre-Merge Checklist

Copy link

vercel bot commented Nov 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2023 2:40am

Copy link

cypress bot commented Nov 8, 2023

Passing run #5114 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 55ea565 into 955c627...
Project: fides Commit: 6deea3095a ℹ️
Status: Passed Duration: 00:32 💡
Started: Nov 8, 2023 2:50 AM Ended: Nov 8, 2023 2:51 AM

Review all test suite changes for PR #4404 ↗︎

@NevilleS NevilleS merged commit 09bf599 into main Nov 8, 2023
@NevilleS NevilleS deleted the ns-fix-consent-banner-classname branch November 8, 2023 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants