Privacy Policy alignment in non-TCF consent overlay banner and modal #4403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
SteveDMurphy
force-pushed
the
sdm-privacy-policy-link-alignment
branch
from
e3bb03c
to
2e907e7
Compare
Passing run #5107 ↗︎
Details:
Review all test suite changes for PR #4403 ↗︎ |
||||||||||||||||||||
NevilleS
approved these changes
Nov 8, 2023
| @@ -64,7 +64,7 @@ const ConsentBanner: FunctionComponent<BannerProps> = ({ | |||
| className={`fides-banner | |||
| fides-banner-bottom | |||
| ${bannerIsOpen ? "" : "fides-banner-hidden"} | |||
| ${className}`} | |||
| ${className ? "" : className}`} | |||
There was a problem hiding this comment.
This fixes an unrelated bug where a class name of "undefined" would be set 👍
| @@ -1007,6 +1007,6 @@ div#fides-banner-inner .fides-privacy-policy { | |||
| div#fides-button-group { | |||
| justify-content: flex-start; | |||
| } | |||
| #fides-privacy-policy-link { | |||
| .fides-tcf-banner-container #fides-privacy-policy-link { | |||
SteveDMurphy
added a commit
that referenced
this pull request
Nov 8, 2023
…4403) Co-authored-by: Neville Samuell <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to PROD-1320
Description Of Changes
As part of the release testing, an issue with alignment for the privacy policy link was identified. The issue impacted the non-TCF modal and overlay
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md