Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing spacing issues caused by a CSS reset #4268

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Fixing spacing issues caused by a CSS reset #4268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59c92bb
Fixing spacing issues caused by a CSS reset
galvana Oct 12, 2023
eb22cfc
Updating change log
galvana Oct 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ The types of changes are:
- Use `stdRetention` when there is not a specific value for a purpose's data retention [#4199](https://github.com/ethyca/fides/pull/4199)
- Updating the unflatten_dict util to accept flattened dict values [#4200](https://github.com/ethyca/fides/pull/4200)
- Minor CSS styling fixes for the consent modal [#4252](https://github.com/ethyca/fides/pull/4252)
- Additional styling fixes for issues caused by a CSS reset [#4268](https://github.com/ethyca/fides/pull/4268)

## [2.21.0](https://github.com/ethyca/fides/compare/2.20.2...2.21.0)

Expand Down
2 changes: 1 addition & 1 deletion clients/fides-js/src/components/fides.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,7 +817,7 @@ div#fides-banner-inner .fides-privacy-policy {
background-color: var(--fides-overlay-background-dark-color);
border-radius: var(--fides-overlay-component-border-radius);
padding: 1.1em;
margin-bottom: 1em;
margin: 1em 0;
}

.fides-info-box p {
Expand Down
2 changes: 1 addition & 1 deletion clients/fides-js/src/components/tcf/TcfVendors.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ const TcfVendors = ({
return (
<div>
{gvlVendor ? <StorageDisclosure vendor={gvlVendor} /> : null}
<div>
<div style={{ marginBottom: "1.1em" }}>
{url?.privacy ? (
<ExternalLink href={url.privacy}>Privacy policy</ExternalLink>
) : null}
Expand Down