Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing spacing issues caused by a CSS reset #4268

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Oct 12, 2023

Description Of Changes

Adding a margin-top to .fides-info-box and an inline margin-bottom to the external links in the fides disclosure

Steps to Confirm

info box
image

disclosure
image

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Oct 12, 2023

Passing run #4606 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge eb22cfc into 44100e2...
Project: fides Commit: 9de05a01f6 ℹ️
Status: Passed Duration: 01:05 💡
Started: Oct 12, 2023 7:16 PM Ended: Oct 12, 2023 7:17 PM

Review all test suite changes for PR #4268 ↗︎

@galvana galvana merged commit 06fe0c6 into main Oct 12, 2023
10 checks passed
@galvana galvana deleted the additional-modal-ui-fixes branch October 12, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants