-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3851 Fix ability to make server side API calls from privacy-center #3895
Conversation
Passing run #3588 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3895 +/- ##
==========================================
- Coverage 87.36% 87.35% -0.02%
==========================================
Files 317 317
Lines 19431 19431
Branches 2497 2497
==========================================
- Hits 16976 16974 -2
- Misses 2023 2024 +1
- Partials 432 433 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick comment- but haven't finished reviewing yet 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits here, but the main two points to get this ready to merge are:
- We should remove the server-side geolocation logic and test this on some feature branches instead
- We should set prefetch to
false
by default, for safety
…ce from server if we have location already
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for forgetting this! Ship it, it's disabled by default, so let's test it out with some staging and production (test) sites
Closes #3851 and #3854
Description Of Changes
This change allows us to, most importantly, be able to fetch experience data on the server-side.
Code Changes
FIDES_PRIVACY_CENTER__SERVER_SIDE_FIDES_API_URL
to set server-side url host (i.e. from one docker container to another)FIDES_PRIVACY_CENTER__IS_PREFETCH_ENABLED
to determine whether or not to make prefetch calls from serverSteps to Confirm
nox -s "fides_env(test)"
http://localhost:3001/fides-js-demo.html
and see that appropriate experience pops upPre-Merge Checklist
CHANGELOG.md