Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable server-side prefetching of geolocation and experience #3854

Closed
eastandwestwind opened this issue Jul 24, 2023 · 1 comment
Closed
Assignees

Comments

@eastandwestwind
Copy link
Contributor

Is your feature request related to a specific problem?

With server-side prefetching was disabled here #3850, but we need to properly implement it

In this ticket, we need to:

  1. Add a config var like FIDES_PRIVACY_CENTER__IS_PREFETCH_ENABLED and have that false to just toggle this behaviour off
  2. When enabled, we should detect ip address from the server header, and forward it to CloudFront using their x-forwarded-for header- https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/RequestAndResponseBehaviorCustomOrigin.html#RequestCustomIPAddresses

Additional context

See #3698 (review) for context

@eastandwestwind eastandwestwind self-assigned this Jul 24, 2023
@eastandwestwind eastandwestwind changed the title Enable server-side prefetching of geolocation and experience Re-enable server-side prefetching of geolocation and experience Jul 24, 2023
@Roger-Ethyca
Copy link
Contributor

moving to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants