Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust max width of system information form #3864

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 26, 2023

Closes #3778

Description Of Changes

Add a max width of 70% at breakpoints lg and above to all components of the "system information" form, to bring them in line with the other system form tabs; also, adjust font weight on "system information" and "data use" forms to match designs. (Below screenshot is on 1440p monitor)

Screenshot 2023-07-26 at 12 19 53 PM

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@cypress
Copy link

cypress bot commented Jul 26, 2023

Passing run #3347 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge fa8653a into 34d4e0d...
Project: fides Commit: 66954bc352 ℹ️
Status: Passed Duration: 01:09 💡
Started: Jul 26, 2023 4:50 PM Ended: Jul 26, 2023 4:51 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@jpople jpople marked this pull request as ready for review July 26, 2023 16:52
@jpople jpople requested a review from allisonking July 26, 2023 17:49
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jpople jpople merged commit f230108 into main Jul 26, 2023
@jpople jpople deleted the 3778-system-form-max-width branch July 26, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add max width to System input fields
2 participants