Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust max width of system information form #3864

Merged
merged 2 commits into from
Jul 26, 2023
Merged

Adjust max width of system information form #3864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
647796c
adjust max width of system information form
jpople Jul 26, 2023
fa8653a
update changelog
jpople Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ The types of changes are:

### Changed
- Simplified the file structure for HTML DSR packages [#3848](https://github.com/ethyca/fides/pull/3848)
- Changed max width of form components in "system information" form tab [#3864](https://github.com/ethyca/fides/pull/3864)

## [2.17.0](https://github.com/ethyca/fides/compare/2.16.0...2.17.0)

Expand Down
12 changes: 3 additions & 9 deletions clients/admin-ui/src/features/system/SystemInformationForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,10 +152,10 @@ const SystemInformationForm = ({
>
{({ dirty, values, isValid }) => (
<Form>
<Stack spacing={6}>
<Stack spacing={6} maxWidth={{ base: "100%", lg: "70%" }}>
{withHeader ? <SystemHeading system={passedInSystem} /> : null}

<Text fontSize="sm">
<Text fontSize="sm" fontWeight="medium">
By providing a small amount of additional context for each system
we can make reporting and understanding our tech stack much easier
for everyone from engineering to legal teams. So let’s do this
Expand All @@ -165,13 +165,7 @@ const SystemInformationForm = ({
System details
</Heading>
<Stack spacing={4}>
{/* While we support both designs of extra form items existing, change the width only
jpople marked this conversation as resolved.
Show resolved Hide resolved
when there are extra form items. When we move to only supporting one design,
the parent container should control the width */}
<Stack
spacing={4}
maxWidth={!abridged ? { base: "100%", lg: "50%" } : undefined}
>
<Stack spacing={4}>
<CustomTextInput
id="name"
name="name"
Expand Down
2 changes: 1 addition & 1 deletion clients/admin-ui/src/features/system/privacy-declarations/PrivacyDeclarationStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ const PrivacyDeclarationStep = ({ system }: Props) => {
<Heading as="h3" size="md">
Data uses
</Heading>
<Text fontSize="sm">
<Text fontSize="sm" fontWeight="medium">
Data Uses describe the business purpose for which the personal data is
processed or collected. Within a Data Use, you assign which categories
of personal information are collected for this purpose and for which
Expand Down