-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notice only rendering #3546
Merged
Merged
Notice only rendering #3546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonking
force-pushed
the
aking/3443/notice-only-rendering
branch
from
June 12, 2023 18:55
ef4f77f
to
b87d7aa
Compare
Passing run #2658 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
allisonking
commented
Jun 13, 2023
eastandwestwind
approved these changes
Jun 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for adding e2e tests too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3443
Code Changes
Steps to Confirm
fides-js-demo-components.html
such that both notices arenotice_only
and have a default preference ofopt_in
(which allnotice_only
notices should have)turbo dev
in thefides-js
folder and visit http://localhost:3000/fides-js-components-demo.htmlPre-Merge Checklist
CHANGELOG.md
Description Of Changes
When only one notice is notice-only
Privacy center if we make a notice notice-only