Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render acknowledge button when there are only notice_only notices #3443

Closed
allisonking opened this issue Jun 2, 2023 · 3 comments · Fixed by #3546
Closed

Render acknowledge button when there are only notice_only notices #3443

allisonking opened this issue Jun 2, 2023 · 3 comments · Fixed by #3546
Assignees

Comments

@allisonking
Copy link
Contributor

allisonking commented Jun 2, 2023

Is your feature request related to a specific problem?

Our fides-js banner currently always renders 3 buttons—Manage preferences, Reject, and Accept, no matter what kind of notice we have.

Notice only notices also have to be disabled and permanently set to true

Describe the solution you'd like

If there are only notice_only notices, we should render an "acknowledge" button instead, and wire up the user preference to pass "acknowledge"

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Design: https://www.figma.com/file/dmEwdK3xZwjKfGVQ9t66xe/Fides-v.2-Master-Working-Files?type=design&node-id=6980-351571&t=6PGfme4Uozj1lLtz-0

@allisonking
Copy link
Contributor Author

A few questions:

  • Do we still render the modal if there are only notice only notices? There's no "Manage preferences" link in the design
    • If yes: they wouldn't be able to change anything, so do we just render one acknowledgment button?
    • If no: then do we also keep a user's link that they use to open up the modal hidden?
  • Same question for the privacy center, what should that page look like when there are only notice only notices?

@allisonking allisonking mentioned this issue Jun 12, 2023
13 tasks
@allisonking
Copy link
Contributor Author

allisonking commented Jun 13, 2023

@mfbrown answered in standup today: yes, we should still show the modal, and then we need the modal to also have the conditional acknowledge button

@Roger-Ethyca
Copy link
Contributor

moving to done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants