Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition with link rendering #3521

Merged
merged 3 commits into from
Jun 12, 2023

Conversation

eastandwestwind
Copy link
Contributor

Closes #3483, closes #3488

Code Changes

  • Implement 200 ms wait before showing the modal link on the page. This does 2 things: 1) Allows some time for the link element to render in the DOM. It was technically possible before that it was not rendered on the page before our fides.js renderFidesOverlay() method was called 2) Since our banner animates after 100 ms, this also gives enough time to ensure the link is not clickable before the banner is displayed on the page.
  • Remove duplicate check for new notices before rendering the banner.

Steps to Confirm

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@cypress
Copy link

cypress bot commented Jun 9, 2023

Passing run #2605 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 8c64b95 into 9a7cf8b...
Project: fides Commit: 9e5f45c919 ℹ️
Status: Passed Duration: 00:58 💡
Started: Jun 9, 2023 8:01 PM Ended: Jun 9, 2023 8:02 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! just one nit :)

clients/fides-js/src/components/Overlay.tsx Outdated Show resolved Hide resolved
@eastandwestwind eastandwestwind merged commit 126ad38 into main Jun 12, 2023
@eastandwestwind eastandwestwind deleted the 3483-race-condition-link-rendering branch June 12, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants