When modal link is clicked before banner animates, both modal and banner render

[eastandwestwind]

          this is a little subtle—the banner always exists, we just move it out of the screen so that we can animate it. the odd thing is that without this change, the env would end up as

showing both the modal and overlay. I think what is happening is

1. the page loads, the banner does not appear yet because it is still animating in
2. cypress clicks on the modal link, so the modal opens (also sets that the banner should not be open, but I think at this point the banner isn't technically open yet because of delayBanner)
3. now the banner has finished animating so both the modal and banner are open!

by waiting for the banner to be visible, that delays cypress enough so that the banner is set to open, then the logic all works accordingly.

this is probably a bug, so maybe it should be skipped instead of the fix I put in 🤔 let me know what you think @eastandwestwind . I think if a user were very speedy, they could trigger this by clicking on the modal link before the banner has appeared

Originally posted by @allisonking in #3487 (comment)

[allisonking]

For a Cypress test case, revert the first line of

fides/clients/privacy-center/cypress/e2e/consent-banner.cy.ts

Lines 948 to 955 in ea3600e

	it("closes banner and opens modal when modal link is clicked", () => {
	cy.get("div#fides-banner").should("be.visible");
	cy.contains("button", "Accept Test").should("exist");
	cy.get("#fides-modal-link").click();
	cy.get("div#fides-banner").should("not.be.visible");
	cy.getByTestId("consent-modal");
	});

from be.visible --> exist

[Roger-Ethyca]

moving to done