Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy experiences initial pages #3186

Merged
merged 10 commits into from
May 5, 2023

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Apr 27, 2023

Closes #3122, closes #3123

Code Changes

  • Update TS autogenerated types
  • Initial page for privacy experiences (table view, edit view)
  • Table for privacy experiences (easy to do thanks to @TheAndrewJackson 's table refactor!)
  • Tweaks to side nav that came up now that we have multiple child side navs
    • Consent page now has its own "page" which just redirects to notices. This makes the "tree" view of the side nav work properly (before I just had the Consent page linking to "/consent/privacy-notices" but that makes "/consent/" not highlight when under "/consent/privacy-experiences" since it doesn't look like part of the same tree)
  • Cypress tests

Steps to Confirm

This is a little tricky to test right now since the backend isn't in main yet, so we can't just use fidesplus double edge. I've found the easiest thing to do is to run the OSS fides backend, then in features.slice.ts, set plus=true instead of the plus health check.

You'll also need a privacy experiences json file to load in, similar to how we load in privacy notices while there aren't any out of the box ones yet.

privacyExperiences.json
[
  {
    "component": "overlay",
    "regions": ["eu_fr", "eu_ie"],
    "delivery_mechanism": "banner"
  },
  {
    "component": "privacy_center",
    "regions": ["us_ca"],
    "delivery_mechanism": "link"
  },
  {
    "component": "overlay",
    "regions": ["eu_de"],
    "delivery_mechanism": "link"
  }
]
  • Click the "Privacy requests" nav link, then in the side nav, click "Privacy experiences"
  • If you've loaded the experiences above, you should see them in the table
  • You should be able to click into a row and go to a work in progress page

Pre-Merge Checklist

Description Of Changes

Screen.Recording.2023-05-02.at.1.39.50.PM.mov

A few things about this table:
image

  • We're punting on how the locations should show up for now. Still need to think through how we will group them and display them
  • The privacy experience table says "Last update" while the notice table says "Last modified". Should we make these consistent @mfbrown ? Simon deferred to you :)
  • The enable/disable button doesn't currently work with the backend yet due to the backend doing more validation than necessary right now. will be fixed soon! Fixed!

image

  • I copied the empty state from notices. I feel like the copy still applies since data uses drive everything, but it might read weird, not sure. Let me know if you want to change this copy @mfbrown

@cypress
Copy link

cypress bot commented Apr 27, 2023

Passing run #1781 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge f90a54a into dd7cfeb...
Project: fides Commit: 6288897473 ℹ️
Status: Passed Duration: 00:50 💡
Started: May 5, 2023 4:06 PM Ended: May 5, 2023 4:07 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@allisonking allisonking force-pushed the aking/3122/privacy-experiences-initial-page branch from 5a0045d to 971ba58 Compare May 2, 2023 17:19
@allisonking allisonking changed the base branch from main to fides_3151_privacy_experiences_endpoints May 2, 2023 17:20
@allisonking allisonking force-pushed the aking/3122/privacy-experiences-initial-page branch 3 times, most recently from 65031cb to 83a7d38 Compare May 2, 2023 17:38
@allisonking allisonking marked this pull request as ready for review May 2, 2023 17:59
@allisonking allisonking force-pushed the aking/3122/privacy-experiences-initial-page branch 2 times, most recently from 590a409 to 878b7e8 Compare May 4, 2023 13:30
@allisonking allisonking mentioned this pull request May 4, 2023
11 tasks
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small nit about the pageSize

Base automatically changed from fides_3151_privacy_experiences_endpoints to main May 4, 2023 19:51
@allisonking allisonking force-pushed the aking/3122/privacy-experiences-initial-page branch from 878b7e8 to f90a54a Compare May 5, 2023 15:49
@allisonking allisonking merged commit 2afdfea into main May 5, 2023
@allisonking allisonking deleted the aking/3122/privacy-experiences-initial-page branch May 5, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table for privacy experiences Initial page for privacy experiences
2 participants