-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Privacy experiences initial pages #3186
Merged
allisonking
merged 10 commits into
main
from
aking/3122/privacy-experiences-initial-page
May 5, 2023
Merged
Privacy experiences initial pages #3186
allisonking
merged 10 commits into
main
from
aking/3122/privacy-experiences-initial-page
May 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing run #1781 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
allisonking
force-pushed
the
aking/3122/privacy-experiences-initial-page
branch
from
May 2, 2023 17:19
5a0045d
to
971ba58
Compare
allisonking
changed the base branch from
main
to
fides_3151_privacy_experiences_endpoints
May 2, 2023 17:20
allisonking
force-pushed
the
aking/3122/privacy-experiences-initial-page
branch
3 times, most recently
from
May 2, 2023 17:38
65031cb
to
83a7d38
Compare
allisonking
commented
May 2, 2023
allisonking
force-pushed
the
aking/3122/privacy-experiences-initial-page
branch
2 times, most recently
from
May 4, 2023 13:30
590a409
to
878b7e8
Compare
TheAndrewJackson
approved these changes
May 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one small nit about the pageSize
clients/admin-ui/src/features/privacy-experience/privacy-experience.slice.ts
Outdated
Show resolved
Hide resolved
allisonking
force-pushed
the
aking/3122/privacy-experiences-initial-page
branch
from
May 5, 2023 15:49
878b7e8
to
f90a54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3122, closes #3123
Code Changes
Steps to Confirm
This is a little tricky to test right now since the backend isn't in
main
yet, so we can't just use fidesplus double edge. I've found the easiest thing to do is to run the OSS fides backend, then infeatures.slice.ts
, setplus=true
instead of the plus health check.You'll also need a privacy experiences json file to load in, similar to how we load in privacy notices while there aren't any out of the box ones yet.
privacyExperiences.json
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Screen.Recording.2023-05-02.at.1.39.50.PM.mov
A few things about this table:
The enable/disable button doesn't currently work with the backend yet due to the backend doing more validation than necessary right now. will be fixed soon!Fixed!