Privacy experience form

[allisonking]

Closes #3126

Code Changes

• Add new PrivacyExperienceForm.tsx
  • This one has a few subcomponents which control the various form rendering logic from privacy experiences
  • Other than that, it's pretty similar to PrivacyNoticeForm.tsx
• Cypress tests, including a handy function to easily test different experiences backed by varying notices

Steps to Confirm

• Same setup as described in Privacy experiences initial pages #3186
• Click into one of the experiences
• You should be able to fill out the form and persist the data

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

Description Of Changes

https://www.loom.com/share/556bc39d3f6b4f7ca50a4c2cef14929a

Screen.Recording.2023-05-04.at.11.31.28.AM.mov

[cypress]

Passing run #1786 ↗︎

0

4

0

0

0

Details:

Merge af2e44a into 2afdfea...
Project: fides	Commit: b3518609d2 ℹ️
Status: Passed	Duration: 00:48 💡
Started: May 5, 2023 7:49 PM	Ended: May 5, 2023 7:50 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[TheAndrewJackson]

I played around with all the example experiences the original PR had and was able to edit everything as expected. I like the implementation for dynamically showing different parts of the form.

I think it was a good choice to not attempt a dynamic validation schema like I did with the custom fields 😅 At least not for the first pass. I wish that formik supported that pattern better.

[allisonking]

I played around with all the example experiences the original PR had and was able to edit everything as expected. I like the implementation for dynamically showing different parts of the form.

I think it was a good choice to not attempt a dynamic validation schema like I did with the custom fields 😅 At least not for the first pass. I wish that formik supported that pattern better.

haha yeah, I thought I could get away with no ValidationSchema, but it turns out we probably do want some validation #3226 so I might have to restructure how this works

[allisonking]

I refactored the form logic a bit in order to accommodate required fields (somewhat dynamic validation schemas—not to the same extent you had to do @TheAndrewJackson in custom fields, since they don't change on user input, just depending on what data is received). I added a hook useExperienceForm to encapsulate the various rule logic, so that all rules can hang out in one place, which hopefully makes adding/editing/removing rules easier

[TheAndrewJackson]

Solid refactor. The new hook cleans the logic up a lot. It's helpful that the validation logic doesn't need to change based on a drop down option! It's still dynamic but not as dynamic as the custom fields form which is nice.

[allisonking]

I had a suspicion my hook was being called more than I wanted it to be and it turned out to be true! so I refactored one more time 😅 this time rules are passed around as props, but I think it works pretty well since the same set of rules get passed everywhere