Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing payment_types connector param #2915

Merged
merged 4 commits into from
Mar 27, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Mar 24, 2023

Closes #2914

Code Changes

  • Removed payment_types from connector params
  • Added ignore_error to payment_method.update request to account for the "payment methods of type us_bank_account cannot be updated at this time." error
  • Updated assertions in the Stripe tests

Pre-Merge Checklist

@galvana galvana linked an issue Mar 24, 2023 that may be closed by this pull request
2 tasks
@cypress
Copy link

cypress bot commented Mar 24, 2023

Passing run #1002 ↗︎

0 3 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge baef63e into 767fe5d...
Project: fides Commit: f42fdc9b16 ℹ️
Status: Passed Duration: 00:50 💡
Started: Mar 24, 2023 5:51 PM Ended: Mar 24, 2023 5:52 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Mar 24, 2023

Codecov Report

Patch coverage has no change and project coverage change: +19.27 🎉

Comparison is base (5f901e1) 67.35% compared to head (baef63e) 86.63%.

❗ Current head baef63e differs from pull request most recent head 99845b5. Consider uploading reports for the commit 99845b5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2915       +/-   ##
===========================================
+ Coverage   67.35%   86.63%   +19.27%     
===========================================
  Files         299      299               
  Lines       16832    16832               
  Branches     2148     2148               
===========================================
+ Hits        11338    14582     +3244     
+ Misses       5092     1841     -3251     
- Partials      402      409        +7     

see 134 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@galvana galvana merged commit d763c71 into main Mar 27, 2023
@galvana galvana deleted the 2914-remove-payment_types-from-stripe-connector-params branch March 27, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove payment_types from Stripe connector params
2 participants