Skip to content

Commit

Permalink
Removing payment_types connector param (#2915)
Browse files Browse the repository at this point in the history
  • Loading branch information
galvana authored Mar 27, 2023
1 parent ff0e747 commit d763c71
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 10 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,8 @@ The types of changes are:
* Changed About Fides page to say "Fides Core Version:" over "Version". [#2899](https://github.com/ethyca/fides/pull/2899)
* Polish Admin UI header & navigation [#2897](https://github.com/ethyca/fides/pull/2897)
* Give new users a "viewer" role by default [#2900](https://github.com/ethyca/fides/pull/2900)
* Tie together save states for user permissions and systems [2913](https://github.com/ethyca/fides/pull/2913)
* Tie together save states for user permissions and systems [#2913](https://github.com/ethyca/fides/pull/2913)
* Removing payment types from Stripe connector params [#2915](https://github.com/ethyca/fides/pull/2915)


### Fixed
Expand Down
8 changes: 2 additions & 6 deletions data/saas/config/stripe_config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,12 @@ saas_config:
name: Stripe
type: stripe
description: A sample schema representing the Stripe connector for Fides
version: 0.0.2
version: 0.0.3

connector_params:
- name: domain
default_value: api.stripe.com
- name: api_key
- name: payment_types

client_config:
protocol: https
Expand Down Expand Up @@ -141,8 +140,6 @@ saas_config:
method: GET
path: /v1/customers/<customer_id>/payment_methods
query_params:
- name: type
value: <type>
- name: limit
value: 100
param_values:
Expand All @@ -151,8 +148,6 @@ saas_config:
- dataset: <instance_fides_key>
field: customer.id
direction: from
- name: type
connector_param: payment_types
data_path: data
pagination:
strategy: cursor
Expand All @@ -161,6 +156,7 @@ saas_config:
field: id
update:
method: POST
ignore_errors: true # payment methods of type us_bank_account cannot be updated at this time.
path: /v1/payment_methods/<payment_method_id>
headers:
- name: Content-Type
Expand Down
4 changes: 1 addition & 3 deletions tests/ops/integration_tests/saas/test_stripe_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ async def test_stripe_access_request_task_with_email(
min_size=2,
keys=[
"billing_details",
"card",
"created",
"customer",
"id",
Expand Down Expand Up @@ -1080,7 +1079,6 @@ async def test_stripe_erasure_request_task(
min_size=2,
keys=[
"billing_details",
"card",
"created",
"customer",
"id",
Expand Down Expand Up @@ -1172,7 +1170,7 @@ async def test_stripe_erasure_request_task(
f"{dataset_name}:card": 1,
f"{dataset_name}:customer_balance_transaction": 0,
f"{dataset_name}:payment_intent": 0,
f"{dataset_name}:payment_method": 2,
f"{dataset_name}:payment_method": 3,
f"{dataset_name}:credit_note": 0,
f"{dataset_name}:bank_account": 1,
f"{dataset_name}:subscription": 1,
Expand Down

0 comments on commit d763c71

Please sign in to comment.