-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route for individual systems #2902
Merged
allisonking
merged 4 commits into
aking/fidesplus-681/system-id-route
from
aking/fidesplus-681/system-id-route-2
Mar 23, 2023
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| import { | ||
| Box, | ||
| Breadcrumb, | ||
| BreadcrumbItem, | ||
| Heading, | ||
| Spinner, | ||
| Text, | ||
| } from "@fidesui/react"; | ||
| import type { NextPage } from "next"; | ||
| import NextLink from "next/link"; | ||
| import { useRouter } from "next/router"; | ||
| import { useEffect } from "react"; | ||
|
|
||
| import { useAppDispatch } from "~/app/hooks"; | ||
| import { SYSTEM_ROUTE } from "~/constants"; | ||
| import Layout from "~/features/common/Layout"; | ||
| import { | ||
| setActiveSystem, | ||
| useGetSystemByFidesKeyQuery, | ||
| } from "~/features/system"; | ||
| import EditSystemFlow from "~/features/system/EditSystemFlow"; | ||
|
|
||
| const ConfigureSystem: NextPage = () => { | ||
| const router = useRouter(); | ||
| const dispatch = useAppDispatch(); | ||
| let systemId = ""; | ||
| if (router.query.id) { | ||
| systemId = Array.isArray(router.query.id) | ||
| ? router.query.id[0] | ||
| : router.query.id; | ||
| } | ||
|
|
||
| const { data: system, isLoading } = useGetSystemByFidesKeyQuery(systemId, { | ||
| skip: !systemId, | ||
| }); | ||
|
|
||
| useEffect(() => { | ||
| dispatch(setActiveSystem(system)); | ||
| }, [system, dispatch]); | ||
|
|
||
| if (isLoading) { | ||
| return ( | ||
| <Layout title="Systems"> | ||
| <Spinner /> | ||
| </Layout> | ||
| ); | ||
| } | ||
|
|
||
| return ( | ||
| <Layout title="Systems"> | ||
| <Heading mb={2} fontSize="2xl" fontWeight="semibold"> | ||
| Configure your system | ||
| </Heading> | ||
| <Box mb={8}> | ||
| <Breadcrumb fontWeight="medium" fontSize="sm" color="gray.600"> | ||
| <BreadcrumbItem> | ||
| <NextLink href={SYSTEM_ROUTE}>System Connections</NextLink> | ||
| </BreadcrumbItem> | ||
| <BreadcrumbItem> | ||
| <NextLink href="#">Configure your connection</NextLink> | ||
| </BreadcrumbItem> | ||
| </Breadcrumb> | ||
| </Box> | ||
| {!system ? ( | ||
| <Text data-testid="system-not-found"> | ||
| Could not find a system with id {systemId} | ||
| </Text> | ||
| ) : ( | ||
| <EditSystemFlow /> | ||
| )} | ||
| </Layout> | ||
| ); | ||
| }; | ||
|
|
||
| export default ConfigureSystem; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that we had different fixtures for 1️⃣ getting a list of systems vs 2️⃣ getting just one system. the tests were pretty dependent on the first system from the list of systems (1️⃣ ), so I made sure to keep that around and index into it, rather than relying on 2️⃣ which had data the tests didn't expect and would've required more changes