-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Route for individual systems #2902
Route for individual systems #2902
Conversation
cy.fixture("systems/systems.json").then((systems) => { | ||
cy.intercept("GET", "/api/v1/system/*", { | ||
body: systems[0], | ||
}).as("getFidesctlSystem"); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that we had different fixtures for 1️⃣ getting a list of systems vs 2️⃣ getting just one system. the tests were pretty dependent on the first system from the list of systems (1️⃣ ), so I made sure to keep that around and index into it, rather than relying on 2️⃣ which had data the tests didn't expect and would've required more changes
Passing run #957 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## aking/fidesplus-681/system-id-route #2902 +/- ##
======================================================================
Coverage ? 86.61%
======================================================================
Files ? 298
Lines ? 16783
Branches ? 2147
======================================================================
Hits ? 14537
Misses ? 1835
Partials ? 411 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💥 I'll update fidesplus to use this soon™️
…us-681/system-id-route-2
Closes https://github.com/ethyca/fidesplus/issues/681
Code Changes
configure
page to beconfigure/[id]
instead. Update the code to always query for the passed in system id on loadSteps to Confirm
/systems
page, click on the more icons and then "Edit"/systems/configure
it'll be/systems/configure/{fides_key}
/systems/configure/{fides_key}
wherefides_key
is one you have in your system/systems/configure/{something_else}
wheresomething_else
is a fides key you do not have in your systemPre-Merge Checklist
CHANGELOG.md
Description Of Changes
Screen.Recording.2023-03-22.at.4.32.58.PM.mov