Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Logo aspect ratio on Privacy Center 404 page and Consent Page #2895

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Fix Logo aspect ratio on Privacy Center 404 page and Consent Page #2895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5d244c1
style: prevent fixed aspect ratio in 404 logo
RobertKeyser Mar 22, 2023
da6ccd6
update CHANGELOG.md for #2895
RobertKeyser Mar 22, 2023
2bf5a5e
remove excess whitespace
RobertKeyser Mar 22, 2023
8d7cd5d
style: prevent fixed aspect ratio in consent page
RobertKeyser Mar 22, 2023
a1ffed0
update changelog for consent logo
RobertKeyser Mar 22, 2023
cf218e5
run prettier
RobertKeyser Mar 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ The types of changes are:
### Changed
* Improved standard layout for large width screens and polished misc. pages [#2869](https://github.com/ethyca/fides/pull/2869)

### Fixed
* Allow for dynamic aspect ratio for logo on Privacy Center 404 [#2895](https://github.com/ethyca/fides/pull/2895)
* Allow for dynamic aspect ratio for logo on consent page [#2895](https://github.com/ethyca/fides/pull/2895)

## [2.9.1](https://github.com/ethyca/fides/compare/2.9.0...2.9.1)

### Added
Expand Down
8 changes: 4 additions & 4 deletions clients/privacy-center/pages/404.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ const Custom404 = () => (
<Image
src={config.logo_path}
alt="Logo"
width="124px"
height="38px"
maxWidth="200px"
maxHeight="100px"
/>
</Box>
</Stack>
Expand All @@ -70,8 +70,8 @@ const Custom404 = () => (
<Image
src={config.logo_path}
alt="Logo"
width="124px"
height="38px"
maxWidth="200px"
maxHeight="100px"
/>
</Link>
</NextLink>
Expand Down
7 changes: 1 addition & 6 deletions clients/privacy-center/pages/consent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,12 +331,7 @@ const Consent: NextPage = () => {
justifyContent="center"
alignItems="center"
>
<Image
src={config.logo_path}
height="56px"
width="304px"
alt="Logo"
/>
<Image src={config.logo_path} height="68px" alt="Logo" />
</Flex>
</header>

Expand Down