Fix Logo aspect ratio on Privacy Center 404 page and Consent Page

[RobertKeyser]

Closes #2893

Code Changes

• Replace 404 logo width/height attributes to maxWidth/maxHeight
• Increase the maxWidth/maxHeight sizes to make the logo appear larger on 404 page
• Remove width constraint from consent page

Steps to Confirm

• Launch privacy center from main (npm run dev)
• Replace the logo in the config.json with a few others:
  • https://upload.wikimedia.org/wikipedia/commons/4/46/Wikipedia-logo-v2-en_6m_articles_204_white.png
  • https://upload.wikimedia.org/wikipedia/commons/8/85/Logo-Test.png
• browse to http://localhost:3000/fake-page
• browse to consent page
• Launch privacy center from this branch (rk-2893-privacy-center-404)
• Repeat testing steps to confirm logos look correct

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated

Description Of Changes

Write some things here about the changes and any potential caveats

[cypress]

Passing run #959 ↗︎

0	3	0	0	0
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.

Details:

Merge cf218e5 into 66acc46...
Project: fides	Commit: d12dc88fba ℹ️
Status: Passed	Duration: 00:39 💡
Started: Mar 23, 2023 3:15 PM	Ended: Mar 23, 2023 3:16 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (c47699c) 86.61% compared to head (cf218e5) 86.60%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2895      +/-   ##
==========================================
- Coverage   86.61%   86.60%   -0.02%     
==========================================
  Files         298      299       +1     
  Lines       16783    16814      +31     
  Branches     2147     2148       +1     
==========================================
+ Hits        14537    14562      +25     
- Misses       1835     1841       +6     
  Partials      411      411              

see 16 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[ThomasLaPiana]

@RobertKeyser do you have screenshots of the diff? We usually prefer to include those for UI changes

[RobertKeyser]

@ThomasLaPiana thanks for the suggestion

Original 404:

Fixed 404:

Original Consent:

Fixed Consent:

[seanpreston]

Thanks @RobertKeyser this works a charm:

I do think there's another conversation we can have in the design loop with regards to how much real estate the privacy centre gives the logos, and this is a great first step.