Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2270 - Search field on privacy request page isn't working #2595

Merged
merged 3 commits into from
Feb 14, 2023

Conversation

chriscalhoun1974
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 commented Feb 14, 2023

Closes #2270

Code Changes

  • Privacy Requests - updated Search textbox placeholder text and disabled spellcheck

Steps to Confirm

Admin UI

  1. Open browser tab and navigate to http://localhost:3000
  2. Login as fides_test user
  3. Click Privacy requests top nav menu item
  4. Verify that the Search textbox placeholder is Search Request ID
  5. Repeat the Privacy Center steps outlined below
  6. Refresh the Admin UI Privacy requests page
  7. Verify that there are 2 DSRs each with a NEW status
  8. Type the Request ID partial value for one of the DSRs
  9. Verify that the corresponding DSR record with the given partial Request ID value is displayed

Privacy Center

  1. Open browser tab and navigate to http://localhost:3001
  2. Click the Access your data card
  3. Input Name, Email, and Phone values
  4. Click the Continue button
  5. Click the Erase your data card
  6. Input Name, Email, and Phone values
  7. Click the Continue button

Pre-Merge Checklist

Screen Shot

Screenshot 2023-02-14 at 5 17 53 PM

@chriscalhoun1974 chriscalhoun1974 marked this pull request as draft February 14, 2023 22:03
@chriscalhoun1974 chriscalhoun1974 changed the title Updated Search textbox placeholder text and disabled spellcheck 2270 - Search field on privacy request page isn't working Feb 14, 2023
@cypress
Copy link

cypress bot commented Feb 14, 2023

Passing run #85 ↗︎

0 3 0 0 Flakiness 0

Details:

Merge f14da1b into 628f473...
Project: fides Commit: 27190ea098 ℹ️
Status: Passed Duration: 00:55 💡
Started: Feb 14, 2023 10:38 PM Ended: Feb 14, 2023 10:39 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@chriscalhoun1974 chriscalhoun1974 requested a review from a team February 14, 2023 22:18
@chriscalhoun1974 chriscalhoun1974 marked this pull request as ready for review February 14, 2023 22:19
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Base: 85.74% // Head: 85.74% // No change to project coverage 👍

Coverage data is based on head (f14da1b) compared to base (628f473).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2595   +/-   ##
=======================================
  Coverage   85.74%   85.74%           
=======================================
  Files         285      285           
  Lines       15477    15477           
  Branches     1945     1945           
=======================================
  Hits        13270    13270           
  Misses       1832     1832           
  Partials      375      375           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ssangervasi ssangervasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍

Copy link
Contributor

@LKCSmith LKCSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@chriscalhoun1974 chriscalhoun1974 merged commit cca5272 into main Feb 14, 2023
@chriscalhoun1974 chriscalhoun1974 deleted the 2270-search-field-on-privacy-request-page branch February 14, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search field on privacy request page isn't working
3 participants