Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search field on privacy request page isn't working #2270

Closed
Roger-Ethyca opened this issue Jan 18, 2023 · 3 comments · Fixed by #2595
Closed

Search field on privacy request page isn't working #2270

Roger-Ethyca opened this issue Jan 18, 2023 · 3 comments · Fixed by #2595
Assignees
Labels
bug Something isn't working

Comments

@Roger-Ethyca
Copy link
Contributor

Bug Description

Search field on the privacy request page isn't searching for anything.

Steps to Reproduce

  1. Log in to the UI and navigate to the Privacy request page.
  2. Have a few requests in various states New, completed, denied and error
  3. Using the search field look for any of the requests.

Expected behavior

The searched DSR or Erasure request should be displayed.

Screen Shot 2023-01-18 at 1 51 06 PM

Screen Shot 2023-01-18 at 1 51 44 PM

If applicable, add screenshots to help explain your problem.

Environment

  • Version:
  • OS:
  • Python Version:
  • Docker Version:

Additional context

Add any other context about the problem here.

@Roger-Ethyca Roger-Ethyca added the bug Something isn't working label Jan 18, 2023
@chriscalhoun1974
Copy link
Contributor

chriscalhoun1974 commented Feb 14, 2023

@Roger-Ethyca @mfbrown @Kelsey-Ethyca Currently, the search field will bring any results based on Request Id value and status filters selected. The API endpoint uses a LIKE clause statement. Thoughts on changing this current behavior?

@Kelsey-Ethyca
Copy link
Contributor

I will defer to @mfbrown for the final decision. My two cents are that today it is unclear what is being searched and there are two ways to fix this..

  1. If we want to leave the placeholder saying "Search" it should search all fields that do not already have a filter (days left, request type, subject identity, and reviewed by). This will require backend work and could cause performance issues if the DSR list is incredibly long.
  2. If we want to search request id only, removing status because there is already a status filter, we should update the search placeholder to say search "Search Request ID". Maybe consider reordering the filters and search to match the order of the column headers. This will still require a small bit of backend work but less likely to cause any performance issues.

@Roger-Ethyca
Copy link
Contributor Author

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants