Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make privacy declarations optional #2173

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Make privacy declarations optional #2173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c938b5a
Make privacy declarations optional
TheAndrewJackson Jan 9, 2023
2ed9687
Update changelog
TheAndrewJackson Jan 9, 2023
45776b3
Merge branch 'main' into ajackson_1976_make_privacy_declartions_optional
TheAndrewJackson Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# Changelog
TheAndrewJackson marked this conversation as resolved.
Show resolved Hide resolved

All notable changes to this project will be documented in this file.

Expand Down Expand Up @@ -39,6 +38,7 @@ The types of changes are:
* Overrides can be saved in the browser.
* Use `NEXT_PUBLIC_APP_ENV` for app-specific environment config.
* No longer use `react-feature-flags` library.
* Made privacy declarations optional when adding systems manually - [#2173](https://github.com/ethyca/fides/pull/2173)
TheAndrewJackson marked this conversation as resolved.
Show resolved Hide resolved
* Dynamic imports of custom overrides and SaaS test fixtures [#2169](https://github.com/ethyca/fides/pull/2169)
* Added `AuthenticatedClient` to custom request override interface [#2171](https://github.com/ethyca/fides/pull/2171)

Expand Down
1 change: 0 additions & 1 deletion clients/admin-ui/src/features/system/PrivacyDeclarationStep.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ const PrivacyDeclarationStep = ({ system, onSuccess, abridged }: Props) => {
<Button
colorScheme="primary"
size="sm"
disabled={formDeclarations.length === 0}
TheAndrewJackson marked this conversation as resolved.
Show resolved Hide resolved
isLoading={isLoading}
data-testid="next-btn"
onClick={handleSubmit}
Expand Down