Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make privacy declarations optional #2173

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Make privacy declarations optional #2173

merged 3 commits into from
Jan 12, 2023

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jan 9, 2023 •
edited
Loading

Closes #1976

Code Changes

  • Remove disable logic on next button

Steps to Confirm

  • Run nox -s dev and run npm run dev from clients/admin-ui
  • Add a system manually
  • Skip adding privacy declarations by just pressing the next button.

Pre-Merge Checklist

Description Of Changes

Pretty straightforward update. This makes it optional to add privacy declarations when adding systems manually.

Optional.Privacy.Declarations.mov

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review January 9, 2023 20:51
@TheAndrewJackson TheAndrewJackson self-assigned this Jan 9, 2023
allisonking
allisonking reviewed Jan 10, 2023
View reviewed changes
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some changelog things, otherwise looks great!

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
clients/admin-ui/src/features/system/PrivacyDeclarationStep.tsx Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Jan 11, 2023

Code Climate has analyzed commit 45776b3 and detected 0 issues on this pull request.

View more on Code Climate.

@TheAndrewJackson TheAndrewJackson merged commit 10137b2 into main Jan 12, 2023
@TheAndrewJackson TheAndrewJackson deleted the ajackson_1976_make_privacy_declartions_optional branch January 12, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonking allisonking allisonking approved these changes

Assignees

@TheAndrewJackson TheAndrewJackson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When adding a system manually it should be optional to add a privacy declaration
2 participants
@TheAndrewJackson @allisonking