Dynamic imports for custom overrides and SaaS fixtures #2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galvana
added
the
run unsafe ci checks
galvana
force-pushed
the
2168-dynamic-imports-for-saas-request-overrides-and-saas-fixtures
branch
from
3fdd4f7
to
792f8c4
Compare
galvana
commented
Jan 9, 2023
adamsachs
approved these changes
Jan 9, 2023
There was a problem hiding this comment.
@galvana this looks good to me, clever dynamic importing within the __init__.py's.
i don't really see a problem with doing this in the fixtures/saas/__init__.py, but is there a specific reason we need to do that now to enable some of your work? mainly just want to avoid quickly changing more than is absolutely necessary, but again, don't really have a specific problem i see with it.
src/fides/api/ops/service/saas_request/override_implementations/__init__.py
Show resolved
Hide resolved
|
Thanks for the review @adamsachs. I updated both the custom overrides module and the SaaS fixtures module because I want to wrap up #1795 before I go on break since AG is close to getting to the point of writing tests for the connectors they've been working on. |
galvana
deleted the
2168-dynamic-imports-for-saas-request-overrides-and-saas-fixtures
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2168
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md