-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SaaS connector test refactoring #1795
Conversation
Code Climate has analyzed commit f58a941 and detected 0 issues on this pull request. View more on Code Climate. |
Passing run #614 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1795 +/- ##
===========================================
+ Coverage 57.05% 86.59% +29.53%
===========================================
Files 291 290 -1
Lines 16458 16224 -234
Branches 2114 2062 -52
===========================================
+ Hits 9390 14049 +4659
+ Misses 6871 1792 -5079
- Partials 197 383 +186
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like this a lot! i think the approach here is great, and i'm excited to see it in action. i'm sure there will be enhancements and improvements that we think of as it gets put to use, but this looks like a great first version to get out into the wild. having this scaffolding to start will be a huge help for connector developers.
i left some comments that are relatively minor, but i think they're worth thinking thru. happy to talk this over more if you'd like!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good @galvana, just a quick follow-up to keep us fully covered please? 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming it passes this latest CI run, let's get this in and start using it!
Closes #1794
Code Changes
init_saas_connector
that creates all the necessary files for a new connectorSteps to Confirm
nox -s init_saas_connector -- Wahoo
and verify the test files are createdPre-Merge Checklist
CHANGELOG.md
Description Of Changes
First iteration, this should ideally accept a connector template as a parameter so it can copy the files into the right locations and inspect the connector parameters to populate the secrets fixtures.