Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filters out identity pairs where val is none or empty string #1907

Merged
merged 3 commits into from
Nov 30, 2022
Merged

filters out identity pairs where val is none or empty string #1907

merged 3 commits into from
Nov 30, 2022

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Nov 30, 2022 •
edited by Kelsey-Ethyca
Loading

Closes #1901

Code Changes

  • Filters out identity pairs where val is none or empty string

Steps to Confirm

  • Log in to the admin ui and setup a connector (i used shopify)
  • Submit a DSR request through the PC using email only (do not add anything else)
  • Log into the admin UI and approve the DSR if manual approvals are turned on
  • The request should succeed

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Write some things here about the changes and any potential caveats

Kelsey-Ethyca
Kelsey-Ethyca approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and its working great :)

@eastandwestwind eastandwestwind merged commit 4261f82 into main Nov 30, 2022
@eastandwestwind eastandwestwind deleted the 1901-filter-empty-identity-vals branch November 30, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelsey-Ethyca Kelsey-Ethyca Kelsey-Ethyca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DSR when approved through ui error
2 participants
@eastandwestwind @Kelsey-Ethyca