DSR when approved through ui error

[Roger-Ethyca]

Bug Description

A description of what the bug is.

Steps to Reproduce

1. Log in to the admin ui and setup a connector (i used shopify)
2. Submit a DSR request through the PC using email only (do not add anything else)
3. Log into the admin UI and approve the DSR
4. The request will return ERROR right away

Expected behavior

The request should be processed through the connector however it looks like when the DSR is submitted on the backend the phone number is empty

If applicable, add screenshots to help explain your problem.

Environment

• Version:
• OS:
• Python Version:
• Docker Version:

Additional context

The persist_identity function in privacy_request.py does not correctly filter out the empty string phone number "" so the SaaS connector validation fails because it sees two identities defined instead of one.

def persist_identity(self, db: Session, identity: Identity) -> None:
        """
        Stores the identity provided with the privacy request in a secure way, compatible with
        blind indexing for later searching and audit purposes.
        """
        identity_dict: Dict[str, Any] = dict(identity)
        for key, value in identity_dict.items():
            if value is not None:
               ...

In saas_query_config.py

def _get_identity(self) -> Optional[str]:
    """
    Returns a single identity or raises an exception if more than one identity is defined
    """

    identities: List[str] = []
    if self.privacy_request:
        identities = list(self.privacy_request.get_cached_identity_data().keys())
        if len(identities) > 1:
            raise FidesopsException(
                "Only one identity can be specified for SaaS connector traversal"
            )
            ...

[Roger-Ethyca]

Verified