-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rescan UI #1844
Merged
Merged
Rescan UI #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allisonking
force-pushed
the
aking/1827/rescan-ui
branch
from
November 23, 2022 22:19
558c0a8
to
7b2fadc
Compare
ssangervasi
reviewed
Nov 28, 2022
ssangervasi
reviewed
Nov 28, 2022
ssangervasi
reviewed
Nov 28, 2022
ssangervasi
approved these changes
Nov 28, 2022
allisonking
force-pushed
the
aking/1827/rescan-ui
branch
from
November 29, 2022 16:27
cbdd433
to
33c7b70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1827
Code Changes
LoadDataFlowScanner
so that it checks whether or not this is a rescan/scan/latest?diff=true
endpoint)systemsToClassify
in redux so that we aren't reusingsystemsToReview
anymoreSteps to Confirm
_app.tsx
make server
in the fidesctl+ repo with scanning enabledPre-Merge Checklist
CHANGELOG.md
Description Of Changes
(video edited to cut out some of the load screen times)
rescan2.mov