Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable rescanning using the scan history diff endpoint #1827

Closed
4 tasks
allisonking opened this issue Nov 18, 2022 · 0 comments · Fixed by #1844
Closed
4 tasks

Enable rescanning using the scan history diff endpoint #1827

allisonking opened this issue Nov 18, 2022 · 0 comments · Fixed by #1844
Assignees

Comments

@allisonking
Copy link
Contributor

allisonking commented Nov 18, 2022

Is your feature request related to a specific problem?

If a user has already done a scan before (there is something in the scan history), then we should render only the added systems in the registration flow. These systems should still go through the classify flow the same way as before.

Describe the solution you'd like

  • Check if this is the first scan (check if GET /api/v1/plus/scan/latest 404s). Assuming it does not 404...
  • After our normal PUT /api/v1/plus/scan, do a GET /api/v1/plus/scan/latest?diff=true to get the diff
  • Render just the added_systems part of the response in the registration table
  • Flow continues as normal

Describe alternatives you've considered, if any

A description of any alternative solutions or features you've considered.

Additional context

Requires https://github.com/ethyca/fidesctl-plus/pull/333.

@allisonking allisonking self-assigned this Nov 18, 2022
@allisonking allisonking mentioned this issue Nov 22, 2022
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant