Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bypass the organization form if organization name and description are already filled out #1840

Merged
merged 3 commits into from
Nov 23, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Nov 22, 2022

Closes #1826

Code Changes

  • Add a useEffect in OrganizationInfoForm.tsx to advance to the next step if the org name and description are already filled out
    • Sneaky removal of a manual useState to keep track of submitting. We can just use formik's built-in isSubmitting prop for the same effect
  • Update cypress tests (had to mess around with the beforeEach's since before the org form would always show up and so all the tests clicked through them. but now it only sometimes shows up depending on the org payload)

Steps to Confirm

  • Clear our your organization's name and description. I use:
UPDATE ctl_organizations SET name = null, description = null where fides_key='default_organization';
  • Go through the config wizard flow and set up an org
  • Go through the flow again. This time, the org form will be skipped

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

Screen.Recording.2022-11-22.at.1.26.18.PM.mov

@allisonking
Copy link
Contributor Author

the tests are failing for the same reason as #1836

@allisonking allisonking marked this pull request as ready for review November 22, 2022 19:54
@allisonking allisonking requested a review from LKCSmith November 22, 2022 19:54
Base automatically changed from aking/1825/reenable-config-wizard to main November 22, 2022 22:41
@allisonking allisonking force-pushed the aking/1826/bypass-organization branch from 7ecacc5 to 4c53abe Compare November 22, 2022 22:43
@allisonking allisonking merged commit 3257d16 into main Nov 23, 2022
@allisonking allisonking deleted the aking/1826/bypass-organization branch November 23, 2022 14:53
Copy link

cypress bot commented Feb 7, 2025

fides    Run #12405

Run Properties:  status check passed Passed #12405  •  git commit 17b75ead4f ℹ️: Merge 8db7a136e4a32e9788bc75f8254541347d9781ad into bfaf0b603eafe8e9a8e5aee77f83...
Project fides
Branch Review LJ-298
Run status status check passed Passed #12405
Run duration 00m 54s
Commit git commit 17b75ead4f ℹ️: Merge 8db7a136e4a32e9788bc75f8254541347d9781ad into bfaf0b603eafe8e9a8e5aee77f83...
Committer erosselli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Feb 12, 2025

fides    Run #12420

Run Properties:  status check passed Passed #12420  •  git commit f3ac0f4b31: LJ-298 Support for GPP string encoding in the backend (#1840)
Project fides
Branch Review main
Run status status check passed Passed #12420
Run duration 00m 53s
Commit git commit f3ac0f4b31: LJ-298 Support for GPP string encoding in the backend (#1840)
Committer erosselli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bypass the organization form if an organization is already set
2 participants